Include action cannot be disabled

[mebeingken]

Wappler Version : 5.4.1
Operating System : mac
Server Model: node
Database Type:
Hosting Type:

Expected behavior

I should be able to disabled an Include action in an api.

Actual behavior

After saving the file, the Include action is re-enabled.

How to reproduce

Add an Include, save.

Disabled the action, save.

Note the action revert to enabled.

report1676747913758.zip (371.2 KB)

[sid]

Similar bug reports have been raised, going back 2 years.

Disabled Include Action should be excluded

OS info Operating System : Windows 10.0.19042 Wappler Version : 3.7.3 Problem description When an Include Action step is disabled, I expect its output to not display. Steps to reproduce Create a Library action with Output enabled in a step. Create an API action with an Include Action step to the above Library action. Disable the Include Action step in the above API action. Click Open in Browser icon. Output from the Library action is shown.

Disabling Library Include Doesn't Work

If you disable a Library Include step, then the actions within it shouldn’t execute Actual behavior They do execute! How to reproduce Create a server action with a library include step which you can run and see it is being activated. Disable that library include step Note that the library include step still executes.

Wappler 5 beta, disabling an include doesn't work

Wappler 5 beta 8 MacOS NodeJS + PostgreSQL Inside a Library action, there’s one Include step that includes another Library action. Disabling this library action and saving the file results in no changes - upon close and re-opening, I see the Include step is still active Replicated consistently - (probably) not related to the other issue of Wappler silently failing to save

On our end, I don’t thing we have used include step since then. We just use Execs. Not because of this bug, but because of our use cases.

[mebeingken]

Looks like it is the intended behavior. No biggie, I can adapt here.

[Antony]

I'm bumping this...

Is it really true that if I set Disable Action Step on an include action then the disable is ignored and the include is executed anyway?

This is what I am seeing in 6.8.0 as it was in 3.9.7...

It seems to be at least very misleading...

... and also preventing a very important debug function!

If I want to see where an error is coming from, to be able to disable an include is extremely useful.

This feels like a bug to me... can someone help me understand why this topic didn't go any further?

[Apple]

@Antony

can someone help me understand why this topic didn't go any further?

So I went to search and found the reason, it's too hard to fix:

Disabled Include Action should be excluded

I see the problem now. The include action step is not an actual action like the rest, it gets replaced with the steps from the included action file. That’s why the disabled is not working, you should disable the steps in the included action file instead. Alternative you could use the exec action step which is an a real step with an output and which can be disabled.

[Antony]

Thanks for that @apple!

Reading through it, there was a plan to not allow includes to be disabled, which it looks like never quite happened...

... not to worry!