Login Error appeared after uploading basic php file

On the live server we have got an issue logging in. I updated to 4.1.2 early this morning. I made a change to a simple php page this morning and now no-one can log in. We get the following error for Login.php which seems to point to the login sequence, but I have changed nothing in this area for a long time.

Can anyone give me some pointers as to what to look at?

1. code: 0
2. file: "/var/www/vhosts/daviesandgray.co.uk/httpdocs/dmxConnectLib/modules/dbconnector.php"
3. line: 70
4. message: "Too few arguments to function modules\\dbconnector::single(), 2 passed in /var/www/vhosts/daviesandgray.co.uk/httpdocs/dmxConnectLib/lib/App.php on line 195 and exactly 3 expected"
5. trace: "#0 /var/www/vhosts/daviesandgray.co.uk/httpdocs/dmxConnectLib/lib/App.php(195): modules\\dbconnector->single(Object(stdClass), 'q_current_user')\n#1 /var/www/vhosts/daviesandgray.co.uk/httpdocs/dmxConnectLib/lib/App.php(159): lib\\App->execSteps(Object(stdClass))\n#2 /var/www/vhosts/daviesandgray.co.uk/httpdocs/dmxConnectLib/lib/App.php(127): lib\\App->execSteps(Array)\n#3 /var/www/vhosts/daviesandgray.co.uk/httpdocs/dmxConnectLib/lib/App.php(116): lib\\App->exec(Object(stdClass), false)\n#4 /var/www/vhosts/daviesandgray.co.uk/httpdocs/dmxConnectLib/lib/App.php(94): lib\\App->exec(Object(stdClass))\n#5 /var/www/vhosts/daviesandgray.co.uk/httpdocs/dmxConnect/api/DG_Admin/Login/Login.php(8): lib\\App->define(Object(stdClass))\n#6 {main}"

Are all new files from dmxConnectLib uploaded to your live site? Seems you have some old and new mixture.

OK, that’s a help, hadn’t thought of that.
I don’t tend to use the ‘Publish’ button, I only ever right-click on the file and select ‘Upload’.
What is your suggestion here? Upload the ‘dmxConnectLib’ folder as a whole?

As a quick test I uploaded the 'dmxConnectLib/lib/App.php' file and everything works as expected.

Should I always 'Publish'?

Yes just to be sure that you have all the latest files first, delete locally dmxConnectLib, then save a server action so that the whole new dmxConnectLib gets generated - and upload this one, publish should generally work fine.

The problem with Publish is that it uploads outdated files, test files, files not yet ready for publishing etc because you cannot exclude files from being published.

That is why I always use the file/upload process.