Issue with cloning from git repository

Hyperbytes · October 30, 2021, 10:10pm

node / Win 11
i am trying to clone a node project i am developing to my laptop via GIT

I pulled the site from a remote Github repository and all the files appear to download correctly

However when Wappler comes to install the node files i get the below output:

Any suggestions as to how to move forward would be appreciated
i can’t install the node modules (node_modules dir) as the node install fails

A workaround is to copy the node_modules directory from a different node install after which things work.

Any suggestions as to how to move forward would be appreciated; should the git repository also hold the node_modules directory content or should wappler be recreating it?

npm ERR! code 1npm ERR! path C:\webs\formichael\node_modules\sqlite3
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c node-gyp rebuild
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using node-gyp@7.1.2
npm ERR! gyp info using node@16.2.0 | win32 | x64
npm ERR! gyp info find Python using Python version 3.10.0 found at "C:\Users\brian\AppData\Local\Programs\Python\Python310\python.exe"
npm ERR! gyp ERR! find VS 
npm ERR! gyp ERR! find VS msvs_version was set from command line or npm config
npm ERR! gyp ERR! find VS - looking for Visual Studio version 2017
npm ERR! gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
npm ERR! gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer, try re-running with '--loglevel silly' for more details
npm ERR! gyp ERR! find VS looking for Visual Studio 2015
npm ERR! gyp ERR! find VS - not found
npm ERR! gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
npm ERR! gyp ERR! find VS 
npm ERR! gyp ERR! find VS valid versions for msvs_version:
npm ERR! gyp ERR! find VS 
npm ERR! gyp ERR! find VS **************************************************************
npm ERR! gyp ERR! find VS You need to install the latest version of Visual Studio
npm ERR! gyp ERR! find VS including the "Desktop development with C++" workload.
npm ERR! gyp ERR! find VS For more information consult the documentation at:
npm ERR! gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
npm ERR! gyp ERR! find VS **************************************************************
npm ERR! gyp ERR! find VS 
npm ERR! gyp ERR! configure error 
npm ERR! gyp ERR! stack Error: Could not find any Visual Studio installation to use
npm ERR! gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\brian\scoop\apps\nodejs\16.2.0\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
npm ERR! gyp ERR! stack     at C:\Users\brian\scoop\apps\nodejs\16.2.0\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:74:16
npm ERR! gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\brian\scoop\apps\nodejs\16.2.0\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
npm ERR! gyp ERR! stack     at C:\Users\brian\scoop\apps\nodejs\16.2.0\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:70:14
npm ERR! gyp ERR! stack     at C:\Users\brian\scoop\apps\nodejs\16.2.0\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:372:16
npm ERR! gyp ERR! stack     at C:\Users\brian\scoop\apps\nodejs\16.2.0\node_modules\npm\node_modules\node-gyp\lib\util.js:54:7
npm ERR! gyp ERR! stack     at C:\Users\brian\scoop\apps\nodejs\16.2.0\node_modules\npm\node_modules\node-gyp\lib\util.js:33:16
npm ERR! gyp ERR! stack     at ChildProcess.exithandler (node:child_process:333:5)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:365:28)
npm ERR! gyp ERR! stack     at maybeClose (node:internal/child_process:1067:16)
npm ERR! gyp ERR! System Windows_NT 10.0.22000
npm ERR! gyp ERR! command "C:\\Users\\brian\\scoop\\apps\\nodejs\\current\\node.exe" "C:\\Users\\brian\\scoop\\apps\\nodejs\\16.2.0\\node_modules\\npm
                                                                                                                                              m\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd C:\webs\formichael\node_modules\sqlite3
npm ERR! gyp ERR! node -v v16.2.0
npm ERR! gyp ERR! node-gyp -v v7.1.2
npm ERR! gyp ERR! not ok

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\brian\scoop\persist\nodejs\cache\_logs\2021-10-30T21_42_09_355Z-debug.log
Error Installing Node Packages!

JonL · October 30, 2021, 10:37pm

The log seems to indicate that it is expecting Microsoft Visual Studio and it can’t find it.

No, node_modules directory shouldn’t be commited to the git repository. Node will read the package.json file and download the node modules you need.

I would sort out the MVS thing first.

Hyperbytes · October 30, 2021, 10:56pm

That was my first thought but MVS 2015 runtime is already installed. I even reinstalled to be safe. Copy the folder over, message disappears even if I reinstall dependencies

JonL · October 30, 2021, 11:06pm

Check these installation notes.

You are probably missing the “Desktop development with C++” package for MSV.

George · October 30, 2021, 11:29pm

You might want to stick to Node 14 for now.

You seem to be on Node 16 and the SQLite package don’t have ready binaries for that and tries to compiles it from source … that needs much more tools to do.

So better for now stick to Node 14.

Hyperbytes · October 30, 2021, 11:29pm

Appreciate you taking the time to look at this Jon.
Sadly i have looked at and followed that post already and it did not solve the problem (just repeated it again 5 mins ago to be sure)

Hyperbytes · October 30, 2021, 11:32pm

Thanks George, never installed node manually at all on this myself. This is a newly reset laptop installed with win 11 and Wappler. Has Wappler installed node 16?

Hyperbytes · October 30, 2021, 11:34pm

Do i need to manually uninstall node 16 and manually reinstall 14 or can it be configured inside Wappler

Hyperbytes · October 31, 2021, 1:29am

after totally screwing my laptop with this i decided to do a full wipe/ reset
I then immediately installed Wappler
It installed node 17.0.1!

JonL · October 31, 2021, 8:50am

Try installing nvm(node version manager) so you can install and select which version you want to use.

George · October 31, 2021, 10:11am

Actually I just checked with Node 16 and it should work just fine.

Are you sure you are on an Intel laptop?

if you installed nodejs on windows with Wappler, then it uses scoop

So you should usually go for the NodeJS LTS version. To do so, run in a terminal:

scoop uninstall nodejs

and then to install the latest NodeJS LTS (16.13.0)

scoop install nodejs-lts

Hyperbytes · October 31, 2021, 11:38am

Yes, Intel i7 8565
Clean install of laptop and Wappler loaded Node v17.0.1 around 1.30am this morning, perhaps you may need to check the install

I can create a blank node project without any problems, the issue seems specifically related to those downloaded from a GIT repository where the “node_modules” folder is not created.
The easy solution was to copy the “node_modules” folder from another node project then run “system, check” and it seems to correct everything

Hyperbytes · October 31, 2021, 11:40am

@George I see your topic title change but I have to disagree as this refers ONLY to the installation of a project from GIT, it is not generally a node install issue and it applies to multiple machines (i checked)

George · October 31, 2021, 11:44am

It doesn’t really matter if it is from git or not, Each new NodeJS project requires the local creation of node_modules - those are the needed nodejs components for the project and they are never stored on git but need to be installed locally.

Installing node modules locally depends on your local node version. So if you have it too new and not all node modules support it yet - the install will fail.

node_modules can contain binary files that are OS specific and also NodeJS version specific. So unless you are copying them from the exact same OS and NodeJS version - you might run into trouble.

Hyperbytes · October 31, 2021, 11:51am

I still don’t see why can i create a blank project without any problems but if i download a project from GIT node install fails? Defies logic
Also as I run “System Check” after copying the folder should that not then correct any incorrect files anyway? It certainly runs with no errors

George · October 31, 2021, 11:55am

hmm - what is the difference in the package.json from the new blank node project and the one you are getting from git?

Maybe there is also a package-lock.json that is coming from the git project? This locks the project to different maybe old versions of the node-modules.

You might want to remove the package-lock.json and then install the node modules again - there is a icon in the toolbar below in the publishing manager - to install the node modules.

Hyperbytes · October 31, 2021, 12:07pm

Thank you George, that was the fix i needed. Pulled another copy down from GIT, deleted “package-lock.json”, ran system check then and it all worked perfectly. Will remove it from GIT now

sid · October 31, 2021, 6:01pm

I encountered this issue few weeks ago.
What worked for me was to simply change the version of some package called “sharp” - something.
I don’t remember if i upgraded or downgraded, but that solved it did me.

Not having package-lock.json in Git is not something that at I have read before in a community discussion. Maybe it would be best if it could be added to future new NodeJS project in Wappler by default @George.

George · October 31, 2021, 8:21pm

Well normally you do have to commit the package-lock.json to git so you lock the exact version of modules used.

See:

You should only delete it if you want to install and update to the latests.