Git Push to remote shows successful even if blocked by github rule

[mebeingken]

Wappler Version : 3.7.2
Operating System : mac
Server Model: node
Database Type: maria
Hosting Type: custom remote

Expected behavior

When pushing to Github, Wappler should report the push as failed if a rule is in place at Github that prevents the push.

Actual behavior

The push is not reflected in github, but Wappler shows it as successful

How to reproduce

Create the following rule which prevents a direct push to the master branch:

Push to the repository from Wappler

Check for the change in github (it will not be there)

Note that Wappler did not present any message indicating the push was blocked.

[patrick]

This seems to be another limitation of the git library we are using. We catch errors that we get on push, but it seems that the blocking doesn’t generate an error, it probably returns the blocking in a return message which the git library ignores.