Change to docker container names

Wappler General
#1

@George @patrick

Did something change within the last few updates to how the docker container names are generated?

I deployed to staging tonight, and after a successful deployment, my caddy server (reverse proxy to docker) was throwing up our maintenance page. I figured out that the container names in caddy no longer matched what wappler generated.

It appears that in certain places, hyphens have replaced underscores.

Can you confirm this is what happened, so I can confidently make the proper changes before hitting production?

Thanks!

#2

We tried to keep docker names all the time tge same, even there is an option to retain old name or use a specific one in the targets dialog.

But we had some cases that we needed to cleanup spaces otherwise bad names were generated and the new docker might be doing also similar things.

So in which certain places you encounter the issue?

#3

Before this issue the container name was:

mpp__staging-do_web_1

Without making any changes to any targets, my most recent deployment named the container:

mpp__staging-do-web-1

It is as if your process for naming the container changed. Not a big deal for me to rename, but I’d have more confidence now pushing to production if you could confirm that such a change was made, else I’m left wondering why it changed.

#4

Here is another data point on this. Different project:

Screen Shot 2022-11-23 at 1.08.25 PM
Screen Shot 2022-11-23 at 1.08.25 PM920×284 33.7 KB

The container names are different from Recreated to Started.

#5

Did you reapply the project targets settings before deploy or just deployed?

#6

Just deployed

#7
#8

Could you check in your .wappler/project.json for the targets do you have a dockerProjectName attribute set there?

and also what is exactly your target name?

#9

From project.json:

"name": "Staging-DO",

"dockerProjectName": "mpp__staging-do",